feat: add .Prefixes() for SilenceManager

pkg/app/alerts_firing.go

@@ -133,7 +133,7 @@ func (a *App) HandleListFiringAlertsWithPagination(
 	for _, alert := range chunk {
 		button := menu.Data(
 			fmt.Sprintf("🔇Silence alert #%d", index+1),
-			silenceManager.GetPrepareSilencePrefix(),
+			silenceManager.Prefixes().PrepareSilence,
 			alert.Alert.GetCallbackHash(),
 		)
 

pkg/app/app.go

@@ -109,13 +109,14 @@ func (a *App) Start() {
 		alertSource := alertSourceWithSilenceManager.AlertSource
 		silenceManager := alertSourceWithSilenceManager.SilenceManager
 		alertSourcePrefixes := alertSourceWithSilenceManager.AlertSource.Prefixes()
+		silencesPrefixes := silenceManager.Prefixes()
 
 		a.Bot.Handle("\f"+alertSourcePrefixes.PaginatedFiringAlerts, a.HandleListFiringAlertsFromCallback(alertSource, silenceManager))
 
-		a.Bot.Handle("\f"+silenceManager.GetPaginatedSilencesListPrefix(), a.HandleListSilencesFromCallback(silenceManager))
-		a.Bot.Handle("\f"+silenceManager.GetUnsilencePrefix(), a.HandleCallbackDeleteSilence(silenceManager))
-		a.Bot.Handle("\f"+silenceManager.GetPrepareSilencePrefix(), a.HandlePrepareNewSilenceFromCallback(silenceManager, alertSource))
-		a.Bot.Handle("\f"+silenceManager.GetSilencePrefix(), a.HandleCallbackNewSilence(silenceManager, alertSource))
+		a.Bot.Handle("\f"+silencesPrefixes.PaginatedSilencesList, a.HandleListSilencesFromCallback(silenceManager))
+		a.Bot.Handle("\f"+silencesPrefixes.Unsilence, a.HandleCallbackDeleteSilence(silenceManager))
+		a.Bot.Handle("\f"+silencesPrefixes.PrepareSilence, a.HandlePrepareNewSilenceFromCallback(silenceManager, alertSource))
+		a.Bot.Handle("\f"+silencesPrefixes.Silence, a.HandleCallbackNewSilence(silenceManager, alertSource))
 	}
 
 	a.Logger.Info().Msg("Telegram bot listening")

pkg/app/silences_create.go

@@ -75,7 +75,7 @@ func (a *App) HandlePrepareNewSilenceFromCallback(
 		for index, mute := range mutesDurations {
 			rows[index] = menu.Row(menu.Data(
 				fmt.Sprintf("⌛ Silence for %s", mute),
-				silenceManager.GetSilencePrefix(),
+				silenceManager.Prefixes().Silence,
 				mute+" "+callback.Data,
 			))
 		}
@@ -143,7 +143,7 @@ func (a *App) HandleNewSilenceGeneric(
 	menu := &tele.ReplyMarkup{ResizeKeyboard: true}
 	menu.Inline(menu.Row(menu.Data(
 		"❌Unsilence",
-		silenceManager.GetUnsilencePrefix(),
+		silenceManager.Prefixes().Unsilence,
 		silence.ID,
 	)))
 

pkg/app/silences_list.go

@@ -83,10 +83,12 @@ func (a *App) HandleListSilencesWithPagination(
 
 	rows := make([]tele.Row, 0)
 
+	prefixes := silenceManager.Prefixes()
+
 	for _, silence := range chunk {
 		button := menu.Data(
 			fmt.Sprintf("❌Unsilence %s", silence.Silence.ID),
-			silenceManager.GetUnsilencePrefix(),
+			prefixes.Unsilence,
 			silence.Silence.ID,
 		)
 
@@ -98,15 +100,15 @@ func (a *App) HandleListSilencesWithPagination(
 		if page >= 1 {
 			buttons = append(buttons, menu.Data(
 				fmt.Sprintf("⬅️Page %d", page),
-				silenceManager.GetPaginatedSilencesListPrefix(),
+				prefixes.PaginatedSilencesList,
 				strconv.Itoa(page-1),
 			))
 		}
 
 		if page < len(silencesGrouped)-1 {
 			buttons = append(buttons, menu.Data(
 				fmt.Sprintf("➡️Page %d", page+2),
-				silenceManager.GetPaginatedSilencesListPrefix(),
+				prefixes.PaginatedSilencesList,
 				strconv.Itoa(page+1),
 			))
 		}

pkg/silence_manager/alertmanager.go

@@ -32,20 +32,13 @@ func (g *Alertmanager) Name() string {
 	return "Alertmanager"
 }
 
-func (g *Alertmanager) GetUnsilencePrefix() string {
-	return constants.AlertmanagerUnsilencePrefix
-}
-
-func (g *Alertmanager) GetSilencePrefix() string {
-	return constants.AlertmanagerSilencePrefix
-}
-
-func (g *Alertmanager) GetPrepareSilencePrefix() string {
-	return constants.AlertmanagerPrepareSilencePrefix
-}
-
-func (g *Alertmanager) GetPaginatedSilencesListPrefix() string {
-	return constants.AlertmanagerPaginatedSilencesList
+func (g *Alertmanager) Prefixes() Prefixes {
+	return Prefixes{
+		PaginatedSilencesList: constants.AlertmanagerPaginatedSilencesList,
+		Silence:               constants.AlertmanagerSilencePrefix,
+		PrepareSilence:        constants.AlertmanagerPrepareSilencePrefix,
+		Unsilence:             constants.AlertmanagerUnsilencePrefix,
+	}
 }
 
 func (g *Alertmanager) GetMutesDurations() []string {

pkg/silence_manager/alertmanager_test.go

@@ -4,7 +4,6 @@ import (
 	"errors"
 	"main/assets"
 	configPkg "main/pkg/config"
-	"main/pkg/constants"
 	loggerPkg "main/pkg/logger"
 	"main/pkg/types"
 	"testing"
@@ -22,10 +21,6 @@ func TestAlertmanagerBasic(t *testing.T) {
 
 	require.True(t, client.Enabled())
 	require.Equal(t, "Alertmanager", client.Name())
-	require.Equal(t, constants.AlertmanagerSilencePrefix, client.GetSilencePrefix())
-	require.Equal(t, constants.AlertmanagerUnsilencePrefix, client.GetUnsilencePrefix())
-	require.Equal(t, constants.AlertmanagerPaginatedSilencesList, client.GetPaginatedSilencesListPrefix())
-	require.Equal(t, constants.AlertmanagerPrepareSilencePrefix, client.GetPrepareSilencePrefix())
 	require.Equal(t, []string{"1h"}, client.GetMutesDurations())
 }
 

pkg/silence_manager/grafana.go

@@ -24,20 +24,13 @@ func InitGrafana(config config.GrafanaConfig, logger *zerolog.Logger) *Grafana {
 	}
 }
 
-func (g *Grafana) GetUnsilencePrefix() string {
-	return constants.GrafanaUnsilencePrefix
-}
-
-func (g *Grafana) GetSilencePrefix() string {
-	return constants.GrafanaSilencePrefix
-}
-
-func (g *Grafana) GetPaginatedSilencesListPrefix() string {
-	return constants.GrafanaPaginatedSilencesList
-}
-
-func (g *Grafana) GetPrepareSilencePrefix() string {
-	return constants.GrafanaPrepareSilencePrefix
+func (g *Grafana) Prefixes() Prefixes {
+	return Prefixes{
+		PaginatedSilencesList: constants.GrafanaPaginatedSilencesList,
+		Silence:               constants.GrafanaSilencePrefix,
+		PrepareSilence:        constants.GrafanaPrepareSilencePrefix,
+		Unsilence:             constants.GrafanaUnsilencePrefix,
+	}
 }
 
 func (g *Grafana) Name() string {

pkg/silence_manager/grafana_test.go

@@ -4,7 +4,6 @@ import (
 	"errors"
 	"main/assets"
 	configPkg "main/pkg/config"
-	"main/pkg/constants"
 	loggerPkg "main/pkg/logger"
 	"main/pkg/types"
 	"testing"
@@ -27,10 +26,6 @@ func TestGrafanaBasic(t *testing.T) {
 
 	require.True(t, client.Enabled())
 	require.Equal(t, "Grafana", client.Name())
-	require.Equal(t, constants.GrafanaSilencePrefix, client.GetSilencePrefix())
-	require.Equal(t, constants.GrafanaUnsilencePrefix, client.GetUnsilencePrefix())
-	require.Equal(t, constants.GrafanaPaginatedSilencesList, client.GetPaginatedSilencesListPrefix())
-	require.Equal(t, constants.GrafanaPrepareSilencePrefix, client.GetPrepareSilencePrefix())
 	require.Equal(t, []string{"1h"}, client.GetMutesDurations())
 }
 

pkg/silence_manager/silence_manager.go

@@ -8,16 +8,20 @@ import (
 	"time"
 )
 
+type Prefixes struct {
+	PaginatedSilencesList string
+	Silence               string
+	PrepareSilence        string
+	Unsilence             string
+}
+
 type SilenceManager interface {
 	GetSilences() (types.Silences, error)
 	GetSilence(silenceID string) (types.Silence, error)
 	CreateSilence(silence types.Silence) (types.SilenceCreateResponse, error)
 	GetSilenceMatchingAlerts(silence types.Silence) ([]types.AlertmanagerAlert, error)
 	DeleteSilence(silenceID string) error
-	GetPaginatedSilencesListPrefix() string
-	GetSilencePrefix() string
-	GetPrepareSilencePrefix() string
-	GetUnsilencePrefix() string
+	Prefixes() Prefixes
 	Name() string
 	Enabled() bool
 	GetMutesDurations() []string

pkg/silence_manager/stub_silence_manager.go

@@ -77,20 +77,13 @@ func (m *StubSilenceManager) DeleteSilence(silenceID string) error {
 	}
 }
 
-func (m *StubSilenceManager) GetSilencePrefix() string {
-	return "stub_silence"
-}
-
-func (m *StubSilenceManager) GetUnsilencePrefix() string {
-	return "stub_unsilence"
-}
-
-func (m *StubSilenceManager) GetPaginatedSilencesListPrefix() string {
-	return "stub_paginate_silences"
-}
-
-func (m *StubSilenceManager) GetPrepareSilencePrefix() string {
-	return "stub_prepare_silence"
+func (m *StubSilenceManager) Prefixes() Prefixes {
+	return Prefixes{
+		Silence:               "stub_silence",
+		Unsilence:             "stub_unsilence",
+		PaginatedSilencesList: "stub_paginated_silences_list",
+		PrepareSilence:        "stub_prepare_silence",
+	}
 }
 
 func (m *StubSilenceManager) Name() string {