Skip to content

initial approach - #14

Open
awordforthat wants to merge 12 commits into
mainfrom
ec/theming
Open

awordforthat wants to merge 12 commits into
mainfrom
ec/theming

Conversation

@awordforthat

@awordforthat awordforthat commented Dec 25, 2024 •

Copy link
Copy Markdown
Collaborator

Implements light theming for dashboard. Some stuff to note:

  1. Required updating mui to the latest version. One component we're using () is deprecated but not broken.
  2. The class name map does some surgery on the flex layout components to selectively apply mui themes to deeply nested layout elements. This is a little janky, but also officially recommended by the author.
  3. Where I added hex colors, they were chosen pretty arbitrarily, change at will.

Probably want to persist the theme to local storage at some point.

Screen caps:

image

image

I just noticed that the handle icon link is broken in the light theme, I'll fix in a separate PR.

@amorygalili amorygalili left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A+

@awordforthat

Copy link
Copy Markdown
Collaborator Author

image

some progress on light mode. The flex layout components can be wired in to the MUI theme using CSS vars. It's a little clunky but so far the only way I've found to do this. I had to upgrade to MUI 6 which has some fallout. LMK what you think.

@awordforthat

Copy link
Copy Markdown
Collaborator Author

Ready for review, fixed the broken plus button

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants