Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.0-alpha Built-in Pop-up missing Close button #27

Closed
BrettEBowman opened this issue Dec 11, 2023 · 5 comments
Closed

v1.0.0-alpha Built-in Pop-up missing Close button #27

BrettEBowman opened this issue Dec 11, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@BrettEBowman
Copy link

BrettEBowman commented Dec 11, 2023

I just installed the new 1.0.0-alpha version. It is a nice improvement!

One bug/problem that I noticed is when I use the built-in pop-up window, I'm not seeing a "X" button to close it. Maybe it is something with my card_mod setup???

Here's my card config:

type: custom:fr24-card
entity: sensor.msp_piaware_flights
providers:
  adsbexchange: false
  flightaware: true
  flightradar24: true
  opensky_network: true
  plane_finder: false
columns:
  - flag
  - registration
  - flight
  - icon
  - altitude
  - speed
  - distance
hide:
  empty:
    - distance
    - altitude
  ground_vehicles: true
popup: true
zone: zone.home
sort: distance
@BrettEBowman BrettEBowman added the bug Something isn't working label Dec 11, 2023
@fratsloos fratsloos self-assigned this Dec 12, 2023
@fratsloos
Copy link
Owner

Thanks for the feedback. I'll have a look at it! 👍

fratsloos added a commit that referenced this issue Dec 18, 2023
fratsloos added a commit that referenced this issue Dec 18, 2023
@fratsloos
Copy link
Owner

The button is not visible because of the config I'm using in browser_mod. I'm hiding the complete header, because it takes a lot of space on smaller screens and it is not really useful. Closing the card is possible by clicking outside of it and the title is below the image.

In the related branch I've changed the config for popup to an object. In this object it is now possible to enable the popup and enable the header of the popup.

I have a few more issues I want to update for a new pre-release. When the pre-release is available you can update it again in HACS.

fratsloos added a commit that referenced this issue Jan 3, 2024
* #27 - Header in popup with config
* #27 - Updated readme
@fratsloos
Copy link
Owner

I've just released the new pre-release with an updated config for the popup. With the new config you can enable the header. This fixes this issue.

@BrettEBowman
Copy link
Author

I can confirm that with the new beta version, I could enable the header (and get the close button).

Note: I had to force a "clear cache and hard reset" in Chrome as reference in this comment.

@fratsloos
Copy link
Owner

Thanks for the update. I was kind of hoping the reload by HACS was enough: on my instance it always gives a warning to reload the browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants