Replace React.PropTypes with the new standalone PropTypes #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fraserxu
reviewed
Apr 20, 2017
| "babel-preset-stage-0": "^6.16.0" | ||
| }, | ||
| "dependencies": { | ||
| "prop-types": "^15.5.8" |
Owner
There was a problem hiding this comment.
What about user using React version < 15.5? Will they have both standalone prop-types and the build in React.PropTypes?
Contributor
Author
There was a problem hiding this comment.
Yes, they will have both.
Contributor
Author
There was a problem hiding this comment.
I would also bump the version of react under peerDependencies to ^0.14.9 || ^0.15.3, since those are the compatible version of the new standalone 'prop-types'. If you don't, and a user has an older version of react, they are going to get this warning: Warning: Failed propType: Calling PropTypes validators directly is not supported by the 'prop-types' package. Use 'PropTypes.checkPropTypes()' to call them..
Owner
|
Thanks @robinsoncol just merged and published to v0.13.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent the warning
Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead., when using react-chartist with React v15.3 and above.