Allow child components and give them access to chartist props #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
fraserxu
reviewed
Jan 28, 2017
index.js
Outdated
| const { className, style, children, data, type } = this.props; | ||
| return ( | ||
| <div className={`ct-chart ${className || ''}`} ref='chart' style={style}> | ||
| {children && cloneElement(children, { type, data })} |
Owner
There was a problem hiding this comment.
are you able to just use {this.props.children} or it's because you need to pass type and data down?
Author
There was a problem hiding this comment.
Yep! I had to use cloneElement to pass down the props to the children.
Owner
There was a problem hiding this comment.
I only used cloneElement method once when I have to passing props down to children with react-router, I've learned from others example it might be better to do a map function over the children in case user passing more than one child.
const children = React.Children.map(this.props.children, child => (
React.cloneElement(child, {
type,
data
})
))
return (
<div>{children}</div>
)
Author
There was a problem hiding this comment.
Yeah, that would work a lot better, especially if more plugins are added later.
Owner
|
Thanks @theslip , new version has published to v0.12.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code to be compatible with react-chartist-plugin-accessibility.