feat(package): chartist 0.10 as peer dependency #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING: as chartist is no longer a solid dependency, it's necessary for react-chartist users to depend on it directly. react-chartist version should be bumped to 0.11.0.
Contributor
Author
|
@fraserxu It would be nice if it could land quickly :) As soon as we have make sure it does not create issues of course ^^ |
fraserxu
reviewed
Nov 15, 2016
package.json
Outdated
| "watchify": "^2.2.1" | ||
| }, | ||
| "peerDependencies": { | ||
| "chartist": "^0.10.1" |
Owner
There was a problem hiding this comment.
Can you move it to the existing peerDependencies above?
Owner
|
Thanks @julien-f I'll merge it and do a new release. |
Owner
|
@julien-f published to v0.11.0 |
This was referenced Nov 15, 2016
Closed
Contributor
Author
|
Thank you so much, I hoped it won't cause any issues! 😛 In any case, should not be a big deal as it's a new major version :) |
Owner
|
0.11.0 is a minor version though |
Contributor
Author
|
Yes, but I meant not compatible with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING: as chartist is no longer a solid dependency, it's necessary for react-chartist users to depend on it directly.
react-chartist version should be bumped to 0.11.0.
Replace both #42 and #43.