Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show the payment button based on the webshop checkout configuration #253

Merged
merged 1 commit into from
Feb 19, 2025
Merged

fix: show the payment button based on the webshop checkout configuration #253

merged 1 commit into from
Feb 19, 2025

Conversation

Bhavan23
Copy link
Contributor

issue: based on checkout configuration, the payment option does not appear correctly.

fix: Use checkout configuration to enable payment.

ref: 29459

Before:

issue_.webm

After:

fix_.webm

backport needed: v15

@Bhavan23 Bhavan23 marked this pull request as ready for review January 31, 2025 11:09
@ruthra-kumar ruthra-kumar self-assigned this Feb 19, 2025
@ruthra-kumar ruthra-kumar self-requested a review February 19, 2025 07:53
@ruthra-kumar ruthra-kumar merged commit fa7c702 into frappe:develop Feb 19, 2025
2 checks passed
@ruthra-kumar
Copy link
Member

@mergify backport version-15

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 19, 2025 •
edited
Loading

backport version-15

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 19, 2025
@Bhavan23 @mergify
fix: show the payment button based on the webshop checkout configurat…
698e289 
…ion (#253)

(cherry picked from commit fa7c702)
@mergify mergify bot mentioned this pull request Feb 19, 2025
Merged
ruthra-kumar pushed a commit that referenced this pull request Feb 19, 2025
@mergify @Bhavan23
fix: show the payment button based on the webshop checkout configurat…
6fc2573 
…ion (#253) (#257)

(cherry picked from commit fa7c702)

Co-authored-by: Bhavansathru <122002510+Bhavan23@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruthra-kumar ruthra-kumar Awaiting requested review from ruthra-kumar

Assignees

@ruthra-kumar ruthra-kumar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bhavan23 @ruthra-kumar