feat(infra): Replace Ansible Implementation with Ansible Runner#4220
feat(infra): Replace Ansible Implementation with Ansible Runner#4220tanmoysrt wants to merge 9 commits intofrappe:developfrom
Conversation
Taken from adityahase/pilot@ab1811a Co-authored-by: Aditya <aditya@adityahase.com>
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (48.01%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #4220 +/- ##
===========================================
- Coverage 50.98% 50.94% -0.05%
===========================================
Files 836 836
Lines 66387 66431 +44
Branches 286 286
===========================================
- Hits 33850 33844 -6
- Misses 32509 32559 +50
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c4cf567 to
a2998a6
Compare
Systemd-timesyncd is installed by default In newer versions of os and that cause conflict
a2998a6 to
681bccb
Compare
On ubuntu 20.04, the service name is ssh.service instead of sshd.service So, try to figure out the servic and then reload
|
I found a few bugs while reviewing and wrote fixes + tests in #5024: Bugs fixed:
Also added 20 unit tests for the pure-logic methods ( Feel free to cherry-pick or I can rebase onto your branch. |
|
will reopen if required |
Copied from https://github.com/adityahase/pilot/blob/ab1811abc64f57676fa466b59d9e0f7b1b3fb712/pilot/infrastructure/ansible.py
press/runner.pywith ansible-runnerSSH Access Audit, replaced duplicate implementation with AnsibleAdHoc with new one.Dependencies -
Tests -