fix: exclude disabled users from approver list#4943
Open
nareshkannasln wants to merge 2 commits into
Open
Conversation
Contributor
Confidence Score: 5/5Safe to merge — the change is narrow, additive, and correctly filters disabled users at the query level. Both the direct lookup path and the department-tree loop correctly add the No files require special attention. Reviews (2): Last reviewed commit: "chore: update query to qb" | Re-trigger Greptile |
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Approver searches in get_approvers() return disabled Users for leave, expense, and shift approvals. Filter both the direct employee approvers and the department-tree approvers on
enabled = 1so deactivated users are no longer selectable.Before:
Screencast.from.2026-07-16.12-53-05.webm
After:
Screencast.from.2026-07-16.12-49-50.webm
Backport needed for v15, v16