fix: Fix standard view filter, UI bugs add My Replies card#3141
Open
pratikb64 wants to merge 9 commits intofrappe:developfrom
Open
fix: Fix standard view filter, UI bugs add My Replies card#3141pratikb64 wants to merge 9 commits intofrappe:developfrom
pratikb64 wants to merge 9 commits intofrappe:developfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3141 +/- ##
===========================================
+ Coverage 55.02% 57.09% +2.06%
===========================================
Files 128 128
Lines 6015 6114 +99
===========================================
+ Hits 3310 3491 +181
+ Misses 2705 2623 -82 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RitvikSardana
requested changes
Mar 25, 2026
Comment on lines
+180
to
+213
| @@ -186,7 +191,12 @@ const masterData = createResource({ | |||
| cache: ["Analytics", "MasterCharts"], | |||
| params: { | |||
| dashboard_type: "master", | |||
| filters, | |||
| filters: { | |||
| from_date: filters.period.split(",")[0], | |||
| to_date: filters.period.split(",")[1], | |||
| team: filters.team, | |||
| agent: filters.agent, | |||
| }, | |||
| }, | |||
| }); | |||
|
|
|||
| @@ -195,7 +205,12 @@ const trendData = createResource({ | |||
| cache: ["Analytics", "TrendCharts"], | |||
| params: { | |||
| dashboard_type: "trend", | |||
| filters, | |||
| filters: { | |||
| from_date: filters.period.split(",")[0], | |||
| to_date: filters.period.split(",")[1], | |||
| team: filters.team, | |||
| agent: filters.agent, | |||
| }, | |||
Member
There was a problem hiding this comment.
since this is being repeated 3 times
make a function
parseFilters and use that
|
|
||
| function formatDateRange(date: string) { | ||
| const d = new Date(date); | ||
| return d.toLocaleDateString("en-US", { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My Repliescard in the agent home page, which will show the number of replies the agent has sent in the given durationHomepage consistent withDashboardpageSLA AlertsandPending Ticketsstandard view filters and added a patch for apply the same