fix: '0' rate LDC's Invoice net totals should be ignored #45639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruthra-kumar
force-pushed
the
incorrect_tds_on_0_rate_ldc
branch
from
51d2c45 to
8955fa7
Compare
ruthra-kumar
force-pushed
the
incorrect_tds_on_0_rate_ldc
branch
from
8955fa7 to
325c4e3
Compare
ruthra-kumar
added
backport version-14-hotfix
This was referenced Feb 7, 2025
ruthra-kumar
added a commit
that referenced
this pull request
Feb 7, 2025
…-45639 fix: '0' rate LDC's Invoice net totals should be ignored (backport #45639)
ruthra-kumar
added a commit
that referenced
this pull request
Feb 13, 2025
…5639) (#45783) * fix: '0' rate LDC's Invoice net totals should be ignored (cherry picked from commit 325c4e3) # Conflicts: # erpnext/accounts/doctype/tax_withholding_category/tax_withholding_category.py * test: ldc @ 0 rate (cherry picked from commit 0cdd346) # Conflicts: # erpnext/accounts/doctype/tax_withholding_category/test_tax_withholding_category.py * chore: resolve conflicts * fix: incorrect parameters * fix: ignore 0 rate ldc invoices --------- Co-authored-by: ruthra kumar <ruthra@erpnext.com>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Feb 19, 2025
# [14.83.0](v14.82.2...v14.83.0) (2025-02-19) ### Bug Fixes * '0' rate LDC's Invoice net totals should be ignored (backport [#45639](#45639)) ([#45783](#45783)) ([534b25c](534b25c)) * add is_new in if condition ([ef37388](ef37388)) * fetch child account data for selected parent ([#45904](#45904)) ([e7d9786](e7d9786)) * include missing payment_gateway parameter in Payment Request URL ([a344b8b](a344b8b)) * millisecond issue for posting datetime ([fc6f568](fc6f568)) * on selection of batch qty is not fetching ([44a16bb](44a16bb)) * pos return validation on v14 ([#45859](#45859)) ([84432fc](84432fc)) * **report:** add options to multiselectlist fields ([aa0ada9](aa0ada9)) * **send_message:** escape HTML in the text ([703fd81](703fd81)) * serial no is mandatory for zero qty validation ([6f6133f](6f6133f)) * set default value to 0 as per new logic ([4b16272](4b16272)) * tests ([e515b91](e515b91)) ### Features * added ability to use custom html format for process statement of accounts ([#45746](#45746)) ([a0cd08e](a0cd08e)) * added option to enforce free item qty in pricing rule ([2edf083](2edf083))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider above scenario, LDC of '0' rate active for December 2024 and thera are purchase invoices booked in that period. Now, when a purchase invoice is created outside LDC, system incorrectly considers net total of pinv1 and pinv2 on TDS calculation as there are no taxes on the previous entries.
todo: