Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply posting date sorting to invoices in Payment Reconciliation similar to payments #44089

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

UmakanthKaspa
Copy link

Summary

In the Payment Reconciliation tool, payment entries are ordered by their posting date, but the invoice entries were not.
This update adds sorting for invoice entries by their posting date in the get_invoice_entries function. The sorting of invoices is now aligned with the sorting applied to payments, ensuring consistency and improving the reconciliation process.

Changes

Updated get_invoice_entries function to sort non_reconciled_invoices by posting_date, similar to the sorting applied in get_nonreconciled_payment_entries to sort payments.

Screenshots

Before Sorting

image

After Sorting

image

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Nov 11, 2024
@ruthra-kumar ruthra-kumar removed the request for review from deepeshgarg007 November 12, 2024 10:27
@ruthra-kumar ruthra-kumar self-assigned this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants