feat(settings): add search bar to settings modal - #2377
Open
TharunikaaM wants to merge 3 commits into
Open
Conversation
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
Contributor
Confidence Score: 5/5This looks safe to merge.
|
| Filename | Overview |
|---|---|
| frontend/src/components/Settings/Settings.vue | Adds sidebar search and keeps the selected settings page aligned with filtered and empty states. |
Reviews (2): Last reviewed commit: "Merge remote-tracking branch 'upstream/d..." | Re-trigger Greptile
Contributor
|
@TharunikaaM this pull request has merge conflicts. Please resolve them so it can be reviewed and merged. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2377 +/- ##
========================================
Coverage 60.53% 60.53%
========================================
Files 142 142
Lines 8550 8550
========================================
Hits 5176 5176
Misses 3374 3374 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a search bar to the Settings modal, making it easier to quickly locate settings without manually scrolling through the sidebar.
Before
Users had to manually browse through different sections to find a specific setting.
After
A search bar is available at the top of the Settings sidebar, allowing users to filter settings live as they type.
Search bar

Searching for a setting

Changes
Testing
Tested the following scenarios:
Fixes #1672