Skip to content

feat(settings): add search bar to settings modal - #2377

Open
TharunikaaM wants to merge 3 commits into
frappe:developfrom
TharunikaaM:feat/settings-search
Open

feat(settings): add search bar to settings modal#2377
TharunikaaM wants to merge 3 commits into
frappe:developfrom
TharunikaaM:feat/settings-search

Conversation

@TharunikaaM

Copy link
Copy Markdown

Summary

This PR adds a search bar to the Settings modal, making it easier to quickly locate settings without manually scrolling through the sidebar.

Before

Users had to manually browse through different sections to find a specific setting.

After

A search bar is available at the top of the Settings sidebar, allowing users to filter settings live as they type.

Search bar
image

Searching for a setting
image

Changes

  • Added a search bar to the top of the Settings sidebar.
  • Filters settings dynamically as the user types.
  • Supports case-insensitive search.
  • Searches across both settings and section names.
  • Displays a "No settings found" message when there are no matching results.
  • Clears the search query when the Settings modal is closed.

Testing

Tested the following scenarios:

  • Live filtering while typing
  • Case-insensitive search
  • Section and setting name matching
  • "No settings found" state
  • Search reset when closing the Settings modal

Fixes #1672

@mergify

mergify Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@greptile-apps

greptile-apps Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
frontend/src/components/Settings/Settings.vue Adds sidebar search and keeps the selected settings page aligned with filtered and empty states.

Reviews (2): Last reviewed commit: "Merge remote-tracking branch 'upstream/d..." | Re-trigger Greptile

Comment thread frontend/src/components/Settings/Settings.vue
Comment thread frontend/src/components/Settings/Settings.vue Outdated
@mergify

mergify Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

@TharunikaaM this pull request has merge conflicts. Please resolve them so it can be reviewed and merged.

@mergify mergify Bot added the conflicts label Jun 29, 2026
@ps173 ps173 self-assigned this Jun 29, 2026
@mergify mergify Bot removed the conflicts label Jun 30, 2026
@codecov-commenter

codecov-commenter commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.53%. Comparing base (7c22813) to head (d898833).
⚠️ Report is 227 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2377   +/-   ##
========================================
  Coverage    60.53%   60.53%           
========================================
  Files          142      142           
  Lines         8550     8550           
========================================
  Hits          5176     5176           
  Misses        3374     3374           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add search bar in settings modal

3 participants