Skip to content

style: highlight selected layers and their nested layers - #846

Open
stravo1 wants to merge 7 commits into
frappe:developfrom
stravo1:layer-selection-style
Open

stravo1 wants to merge 7 commits into
frappe:developfrom
stravo1:layer-selection-style

Conversation

@stravo1

@stravo1 stravo1 commented Sep 21, 2026 •

Copy link
Copy Markdown
Member

Changes

  • Give a selected layer a blue background. Use a darker blue in dark mode.
  • Give the layers nested in a selected layer a gray background. The gray background is on the nested layer tree, so the rounded corners of a nested layer do not show the blue background.

Before this change, a single outline showed the selected block. The new backgrounds show more clearly which blocks are selected.

Screen.Recording.2026-09-17.at.9.34.01.PM.mp4

Dark mode:

Screenshot 2026-09-17 at 9 34 30 PM

Split from #839.

stravo1 and others added 2 commits September 21, 2026 12:10
Give a selected layer a blue background. Give the layers nested in it a
gray background, in place of the old nested selected style.

Co-Authored-By: Claude <noreply@anthropic.com>
Put the gray background on the nested layer tree, not on each nested
layer. The rounded corners of a nested layer no longer show the blue
background of the selected layer. Hover borders keep rounded corners.

Use a darker blue background for a selected layer in dark mode.

Co-Authored-By: Claude <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Reviews (5) · Last reviewed commit: "fix: end the layer drop line at the row ..." · Reviewed by Greptile

Comment thread frontend/src/components/BlockLayers.vue
@stravo1

stravo1 commented Sep 21, 2026

Copy link
Copy Markdown
Member Author

Grays:
Screenshot 2026-09-18 at 11 05 37 AM

Blues:
Screenshot 2026-09-18 at 11 06 26 AM

Screen.Recording.2026-09-18.at.11.11.58.AM.mp4

In my opinion we should stick to blue as we also show the actual block selection in the canvas with a blue border, this feels more consistent (also blue is the accent color of Builder).

@codecov

codecov Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.58%. Comparing base (acb6d17) to head (bf46257).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #846   +/-   ##
========================================
  Coverage    72.58%   72.58%           
========================================
  Files          107      107           
  Lines        11918    11918           
========================================
  Hits          8651     8651           
  Misses        3267     3267           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@surajshetty3416
surajshetty3416 marked this pull request as draft September 24, 2026 09:55
stravo1 and others added 2 commits October 13, 2026 01:16
The selected row gets a solid blue fill. Its nested layers get a
lighter blue tint, so the selection reads as one rounded group.
Hover fills the row with blue and rounds it, except inside a
selection, where rows stay square.

The colors use the surface-blue tokens, so they follow the theme.

Co-Authored-By: Claude <noreply@anthropic.com>
@stravo1

stravo1 commented Oct 12, 2026

Copy link
Copy Markdown
Member Author

Updates styles:

Light Mode

Screen.Recording.2026-10-13.at.4.12.30.AM.mp4

Dark Mode

Screen.Recording.2026-10-13.at.4.12.03.AM.mp4

@stravo1
stravo1 marked this pull request as ready for review October 12, 2026 22:44
@stravo1

stravo1 commented Oct 12, 2026

Copy link
Copy Markdown
Member Author

@surajshetty3416 please tweak the colors if needed.

Comment thread frontend/src/components/BlockLayers.vue
The drop highlight now goes on the row, with the same radius as the
hover. Before, the selected row fill covered it.

The drop line now uses fixed positioning. A selected group clips its
contents with overflow-hidden, so a line from a nested list did not
show when a layer was dragged out of the group.

Co-Authored-By: Claude <noreply@anthropic.com>
Comment thread frontend/src/components/BlockLayers.vue Outdated
Comment thread frontend/src/components/BlockLayers.vue Outdated
stravo1 and others added 2 commits October 13, 2026 06:11
A fixed line did not scroll with the layers panel, and the panel did
not clip it. The top-level tree now draws the line, and nested lists
set its position through provide and inject. The line scrolls with
the tree, the panel clips it, and a selected group cannot clip it.

Co-Authored-By: Claude <noreply@anthropic.com>
The line used the width of the tree container, which includes its
right padding, so it ran past the rows. It now ends at the right
edge of the target row.

Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant