Polish BearerTokenAuthenticationConverter #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove AuthenticationDetailsSource. The filter can continue handling this so that it can be added later - Applied an adapter so the configurer and the filter are always utlimately using an AuthenticationConverter - Changed bean capture to focus on BearerTokenAuthenticationConverter so the converter doesn't pick up converters for other filters Issue spring-projectsgh-14750
- Moved BearerTokenAuthenticationConverter to web.authentication - Fixed bug in adapter where resolver was called twice Issue spring-projectsgh-14750
The same bug appeared in a similar adapter in BearerTokenAuthenticationFilter
franticticktick
force-pushed
the
gh-14750
branch
3 times, most recently
from
e4fbf43 to
e39e608
Compare
franticticktick
force-pushed
the
gh-14750
branch
from
e39e608 to
ee09666
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@franticticktick, I think these changes will get us back on track for this PR. If you agree, please merge and we can continue reviewing your PR together
Issue spring-projectsgh-14750