Demo a merge batcher that uses the container builder#4
Closed
antiguru wants to merge 2 commits intofrankmcsherry:columnar_builderfrom
Closed
Demo a merge batcher that uses the container builder#4antiguru wants to merge 2 commits intofrankmcsherry:columnar_builderfrom
antiguru wants to merge 2 commits intofrankmcsherry:columnar_builderfrom
Conversation
5ab4ee7 to
9957bd5
Compare
5bb9784 to
cecae53
Compare
9957bd5 to
5c61b40
Compare
843ac7f to
a6bbef6
Compare
* Demonstrate Columnar batch builder * Correct example, improve chunking * Simplify constraints * Form key batches in columnar Signed-off-by: Moritz Hoffmann <antiguru@gmail.com> --------- Signed-off-by: Moritz Hoffmann <antiguru@gmail.com> Co-authored-by: Moritz Hoffmann <antiguru@gmail.com>
Signed-off-by: Moritz Hoffmann <antiguru@gmail.com> # Conflicts: # Cargo.toml # differential-dataflow/Cargo.toml # differential-dataflow/examples/columnar.rs Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
d8ff8b3 to
e2970f8
Compare
Author
|
Superseded by TimelyDataflow#613 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the merge batcher to use a container builder to produce its output. This introduces several interesting behavior and unfortunate code changes:
copy_descructuredfor timely stacks :(clearrecycled allocations. This is because in columnar, a clear moves a column from any variant to typed, potentially discarding its allocation. Avoiding the clear call might leave some memory sitting around for a bit longer, but the container builders are used to clearing on re-use, so no problems expected on that side.The PR is in the wrong order, the merge batcher changes should go into master and then the columnar builder should pick up the new interface. But, this is how I started so I'm leaving it as-is until we talk about it.