Remove all sslverify false

Closes woocommerce#8058 cc @claudiosmweb @roykho @barrykooij
frankiejarrett · May 5, 2015 · 5a92126 · 5a92126
1 parent 7254e45
commit 5a92126
Show file tree

Hide file tree

Showing 7 changed files with 6 additions and 11 deletions.
diff --git a/includes/admin/class-wc-admin-welcome.php b/includes/admin/class-wc-admin-welcome.php
@@ -404,7 +404,7 @@ public function get_contributors() {
 			return $contributors;
 		}
 
-		$response = wp_remote_get( 'https://api.github.com/repos/woothemes/woocommerce/contributors', array( 'sslverify' => false ) );
+		$response = wp_remote_get( 'https://api.github.com/repos/woothemes/woocommerce/contributors' );
 
 		if ( is_wp_error( $response ) || 200 != wp_remote_retrieve_response_code( $response ) ) {
 			return array();

diff --git a/includes/admin/views/html-admin-page-status-report.php b/includes/admin/views/html-admin-page-status-report.php
@@ -224,7 +224,6 @@
 			$posting['wp_remote_post']['help'] = '<a href="#" class="help_tip" data-tip="' . esc_attr__( 'PayPal uses this method of communicating when sending back transaction information.', 'woocommerce' ) . '">[?]</a>';
 
 			$response = wp_remote_post( 'https://www.paypal.com/cgi-bin/webscr', array(
-				'sslverify'  => false,
 				'timeout'    => 60,
 				'user-agent' => 'WooCommerce/' . WC()->version,
 				'body'       => array(

diff --git a/includes/class-wc-language-pack-upgrader.php b/includes/class-wc-language-pack-upgrader.php
@@ -109,7 +109,7 @@ public function configure_woocommerce_upgrade_notice() {
 	 * @return bool
 	 */
 	public function check_if_language_pack_exists() {
-		$response = wp_remote_get( $this->get_language_package_uri(), array( 'sslverify' => false, 'timeout' => 60 ) );
+		$response = wp_remote_get( $this->get_language_package_uri(), array( 'timeout' => 60 ) );
 
 		if ( ! is_wp_error( $response ) && $response['response']['code'] >= 200 && $response['response']['code'] < 300 ) {
 			return true;
@@ -188,7 +188,7 @@ public function manual_language_update() {
 			}
 
 			// Download the language pack
-			$response = wp_remote_get( $this->get_language_package_uri(), array( 'sslverify' => false, 'timeout' => 60 ) );
+			$response = wp_remote_get( $this->get_language_package_uri(), array( 'timeout' => 60 ) );
 			if ( ! is_wp_error( $response ) && $response['response']['code'] >= 200 && $response['response']['code'] < 300 ) {
 				global $wp_filesystem;
 

diff --git a/includes/class-wc-webhook.php b/includes/class-wc-webhook.php
@@ -191,7 +191,6 @@ public function deliver( $arg ) {
 			'timeout'     => MINUTE_IN_SECONDS,
 			'redirection' => 0,
 			'httpversion' => '1.0',
-			'sslverify'   => false,
 			'blocking'    => true,
 			'user-agent'  => sprintf( 'WooCommerce/%s Hookshot (WordPress/%s)', WC_VERSION, $GLOBALS['wp_version'] ),
 			'body'        => trim( json_encode( $payload ) ),

diff --git a/includes/gateways/paypal/includes/class-wc-gateway-paypal-ipn-handler.php b/includes/gateways/paypal/includes/class-wc-gateway-paypal-ipn-handler.php
@@ -76,7 +76,6 @@ public function validate_ipn() {
 		// Send back post vars to paypal
 		$params = array(
 			'body'        => $validate_ipn,
-			'sslverify'   => false,
 			'timeout'     => 60,
 			'httpversion' => '1.1',
 			'compress'    => false,
@@ -184,9 +183,9 @@ protected function payment_status_completed( $order, $posted ) {
 
 			if ( ! empty( $posted['mc_fee'] ) ) {
 				// log paypal transaction fee
-				update_post_meta( $order->id, 'PayPal Transaction Fee', wc_clean( $posted['mc_fee'] ) ); 
+				update_post_meta( $order->id, 'PayPal Transaction Fee', wc_clean( $posted['mc_fee'] ) );
 			}
-			
+
 		} else {
 			$this->payment_on_hold( $order, sprintf( __( 'Payment pending: %s', 'woocommerce' ), $posted['pending_reason'] ) );
 		}

diff --git a/includes/gateways/paypal/includes/class-wc-gateway-paypal-pdt-handler.php b/includes/gateways/paypal/includes/class-wc-gateway-paypal-pdt-handler.php
@@ -36,7 +36,6 @@ protected function validate_transaction( $transaction ) {
 				'tx'  => $transaction,
 				'at'  => $this->identity_token
 			),
-			'sslverify' 	=> false,
 			'timeout' 		=> 60,
 			'httpversion'   => '1.1',
 			'user-agent'	=> 'WooCommerce/' . WC_VERSION
@@ -78,7 +77,7 @@ public function check_response() {
 
 				if ( ! empty( $_REQUEST['mc_fee'] ) ) {
 					// log paypal transaction fee
-					update_post_meta( $order->id, 'PayPal Transaction Fee', wc_clean( $_REQUEST['mc_fee'] ) ); 
+					update_post_meta( $order->id, 'PayPal Transaction Fee', wc_clean( $_REQUEST['mc_fee'] ) );
 				}
 			}
 		}

diff --git a/includes/gateways/paypal/includes/class-wc-gateway-paypal-refund.php b/includes/gateways/paypal/includes/class-wc-gateway-paypal-refund.php
@@ -59,7 +59,6 @@ public static function refund_order( $order, $amount = null, $reason = '', $sand
 				'method'      => 'POST',
 				'body'        => self::get_request( $order, $amount, $reason ),
 				'timeout'     => 70,
-				'sslverify'   => false,
 				'user-agent'  => 'WooCommerce',
 				'httpversion' => '1.1'
 			)