revert log-breaking change and add comments (airbytehq#4303)

frankfanslc · Jun 23, 2021 · 0e5ec6a · 0e5ec6a
1 parent 38ed70c
commit 0e5ec6a
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/.env b/.env
@@ -36,3 +36,11 @@ TRACKING_STRATEGY=segment
 WEBAPP_URL=http://localhost:8000/
 API_URL=/api/v1/
 INTERNAL_API_HOST=airbyte-server:8001
+
+# Cloud log backups. Don't use this unless you know what you're doing.
+# If you just want to capture Docker logs, you probably want to use something like this instead:
+# https://docs.docker.com/config/containers/logging/configure/
+S3_LOG_BUCKET=
+S3_LOG_BUCKET_REGION=
+AWS_ACCESS_KEY_ID=
+AWS_SECRET_ACCESS_KEY=
diff --git a/docker-compose.yaml b/docker-compose.yaml
@@ -57,6 +57,10 @@ services:
       - AIRBYTE_VERSION=${VERSION}
       - AIRBYTE_ROLE=${AIRBYTE_ROLE:-}
       - TEMPORAL_HOST=${TEMPORAL_HOST}
+      - S3_LOG_BUCKET=${S3_LOG_BUCKET}
+      - S3_LOG_BUCKET_REGION=${S3_LOG_BUCKET_REGION}
+      - AWS_ACCESS_KEY_ID=${AWS_ACCESS_KEY_ID}
+      - AWS_SECRET_ACCESS_KEY=${AWS_SECRET_ACCESS_KEY}
     volumes:
       - /var/run/docker.sock:/var/run/docker.sock
       - workspace:${WORKSPACE_ROOT}
@@ -81,6 +85,10 @@ services:
       - AIRBYTE_VERSION=${VERSION}
       - AIRBYTE_ROLE=${AIRBYTE_ROLE:-}
       - TEMPORAL_HOST=${TEMPORAL_HOST}
+      - S3_LOG_BUCKET=${S3_LOG_BUCKET}
+      - S3_LOG_BUCKET_REGION=${S3_LOG_BUCKET_REGION}
+      - AWS_ACCESS_KEY_ID=${AWS_ACCESS_KEY_ID}
+      - AWS_SECRET_ACCESS_KEY=${AWS_SECRET_ACCESS_KEY}
     ports:
       - 8001:8001
     volumes: