Cosmetic changes to xacro and launch files #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 25, 2021
3 tasks
rhaschke
force-pushed
the
improve-xacro-parameterization
branch
2 times, most recently
from
f6b4a42
to
43a7a05
Compare
|
I simplified this PR as discussed in the video conference (and further), namely:
So for now, this PR only comprises cosmetic but no sematic changes. |
rhaschke
force-pushed
the
improve-xacro-parameterization
branch
from
43a7a05
to
a4dfb68
Compare
rhaschke
changed the title
rhaschke
force-pushed
the
improve-xacro-parameterization
branch
2 times, most recently
from
baf2fd0
to
d78f0e5
Compare
rhaschke
added a commit
to rhaschke/franka_ros
that referenced
this pull request
Oct 27, 2021
…ika#186, and frankaemika#187 into develop
|
LGTM |
rhaschke
added a commit
to rhaschke/franka_ros
that referenced
this pull request
Oct 28, 2021
No need to declare an intermediate property
... to hide them in the final URDF
... avoiding code duplication
... to clarify that this node requires the remapping.
rhaschke
force-pushed
the
improve-xacro-parameterization
branch
from
d78f0e5
to
bd69b61
Compare
13 tasks
rhaschke
added a commit
to rhaschke/franka_ros
that referenced
this pull request
Nov 7, 2021
11 tasks
|
Looks good. Let's merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comprises some simple cosmetic changes and cleanup to xacro files.
Please don't squash-merge. All commits are rather independent. See individual commit messages for details.