Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust AlarmQuery Date Bounds to Cover Full Days #1353

Merged

Conversation

mauroalexandre
Copy link
Contributor

Purpose

This pull request adjusts the time boundaries of the AlarmQuery to ensure that the query encompasses the entire day from the start date to the end date. Previously, the query might not have included all events from the start and end of each day if events occurred at the very beginning or end of the day.

Changes

  • Set the start time to 00:00:00.000 on the start date, ensuring the query covers all events from the very first second of the day.
  • Set the end time to 23:59:59.999 on the end date, ensuring the query covers all events until the very last millisecond of the day.

Justification

Adjusting the start and end times of the AlarmQuery helps in generating complete data for daily reports, ensuring no data is missed due to time boundary issues. This is particularly useful in scenarios where precise data logging and reporting are critical, such as in security or monitoring applications.

Please review the changes and merge them if everything looks good. Thank you!

@unocelli
Copy link
Member

unocelli commented Sep 4, 2024

Good job, Thanks again

@unocelli unocelli merged commit ba1d52d into frangoteam:master Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants