Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 350ms Polling Interval Option for PLC #1347

Conversation

mauroalexandre
Copy link
Contributor

This pull request introduces the option to set the PLC polling interval to 350ms. Although this might seem like a minor change, in certain scenarios—like the one I'm encountering—this adjustment in polling time is critical and could benefit other users of the project.

Thank you for considering this change, and I'm open to discussing it further.

Thank you!

@PedroHDDomingos
Copy link

Important improvement for small PLCs where we normally cannot work with 200ms.

@MatthewReed303
Copy link
Collaborator

I feel we should start from 100ms with 50ms increments or have ability to enter in custom polling number. High performance systems can do 100ms no problem and great for real time motion control applications where trending updates and PID tuning is important on high speed systems. What are your thoughts on this @unocelli

@PedroHDDomingos
Copy link

Excellent @MatthewReed303, I believe that 50 to 50ms would be enough, today there is a jump from 200 to 500ms, this makes fine adjustment very difficult.

@unocelli
Copy link
Member

unocelli commented Sep 4, 2024

I am positively for adding 50, 100, 150, 350

@unocelli
Copy link
Member

unocelli commented Sep 4, 2024

@mauroalexandre Thanks, I will merge this PR and add later the other values.

@unocelli unocelli merged commit 8649370 into frangoteam:master Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants