Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to react-router@6.x #147

Merged
merged 2 commits into from
Mar 22, 2022

Conversation

MarkLyck
Copy link
Contributor

@MarkLyck MarkLyck commented Mar 12, 2022

Upgrade react-router to version 6.

This solves #127

@MarkLyck MarkLyck changed the title feat: upgrade to react-router@6.x chore: upgrade to react-router@6.x Mar 12, 2022
@frandiox
Copy link
Owner

@MarkLyck Thanks! I can confirm this works after updating test/fixtures/react-ts-basic. However, I still need to check if it still works with vitedge package, which is wrapping this one.

I see React Router 6 is renaming the routes syntax:

  • route.routes => route.children
  • route.component => route.element

I wonder if we should also update the API in vite-ssr/react for this 🤔

@frandiox frandiox merged commit 4ef15c6 into frandiox:master Mar 22, 2022
@frandiox
Copy link
Owner

@MarkLyck Released in 0.16.0, thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants