Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#89): add check to the statusCode setter in ResponseProperties - fixes #89 #90

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

francescovallone
Copy link
Owner

Description

Add a check to the statusCode setter in the ResponseProperties object

Fixes #89

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@francescovallone francescovallone linked an issue Sep 17, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.81%. Comparing base (cfbbf65) to head (19fb230).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #90      +/-   ##
===========================================
+ Coverage    89.75%   89.81%   +0.06%     
===========================================
  Files           73       74       +1     
  Lines         2605     2622      +17     
===========================================
+ Hits          2338     2355      +17     
  Misses         267      267              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@francescovallone francescovallone merged commit 4849bce into develop Sep 17, 2024
6 checks passed
@francescovallone francescovallone deleted the fix/89 branch September 17, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: set a range for the statusCode
1 participant