Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: simplify setGlobalPrefix method in Serinus (closes #73) #75

Merged
merged 4 commits into from
Sep 8, 2024

Conversation

francescovallone
Copy link
Owner

Description

The utility class will be used only for internal reference, the users can now use a simple string to manage the global prefix.

Also the method setGlobalPrefix has been changed with an actual setter called globalPrefix

Fixes #73

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@francescovallone francescovallone linked an issue Sep 8, 2024 that may be closed by this pull request
1 task
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.26%. Comparing base (b063a69) to head (937962a).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #75      +/-   ##
===========================================
+ Coverage    89.03%   89.26%   +0.22%     
===========================================
  Files           74       74              
  Lines         2417     2449      +32     
===========================================
+ Hits          2152     2186      +34     
+ Misses         265      263       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@francescovallone francescovallone changed the base branch from main to develop September 8, 2024 18:26
@francescovallone francescovallone merged commit 76bf981 into develop Sep 8, 2024
11 checks passed
@francescovallone francescovallone deleted the feat/73 branch September 8, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: simplify setGlobalPrefix method in Serinus
1 participant