Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#42): accept List<JsonObject> as possible data in Response.json #43

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

francescovallone
Copy link
Owner

Description

The Response.json can now parse more complex objects.

Fixes #42

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.58%. Comparing base (edfb04b) to head (1e7b55c).
Report is 2 commits behind head on develop.

Files Patch % Lines
packages/serinus/lib/src/http/response.dart 82.35% 3 Missing ⚠️
packages/serinus/bin/serinus.dart 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #43      +/-   ##
===========================================
- Coverage    88.69%   84.58%   -4.11%     
===========================================
  Files           65       66       +1     
  Lines         1963     2083     +120     
===========================================
+ Hits          1741     1762      +21     
- Misses         222      321      +99     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@francescovallone francescovallone changed the title Fix/42 fix(#42): accept List<JsonObject> as possible data in Response.json Jun 27, 2024
@francescovallone francescovallone linked an issue Jun 27, 2024 that may be closed by this pull request
@francescovallone francescovallone merged commit cf0a34f into develop Jun 27, 2024
1 of 3 checks passed
@francescovallone francescovallone deleted the fix/42 branch June 27, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: accept List<JsonObject> as possible data in Response.json
1 participant