Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#16): add factory constructors to Route and remove abstract modifier #24

Merged
merged 2 commits into from
Jun 9, 2024

Conversation

francescovallone
Copy link
Owner

@francescovallone francescovallone commented Jun 9, 2024

Description

To reduce the classes needed to develop a Serinus Application, the Route class has been made a concrete one and the factory constructors required have been implemented.

Fixes #16

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@francescovallone francescovallone self-assigned this Jun 9, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.12%. Comparing base (faaadf6) to head (42af888).
Report is 7 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #24      +/-   ##
===========================================
+ Coverage    86.93%   87.12%   +0.19%     
===========================================
  Files           69       70       +1     
  Lines         1959     1989      +30     
===========================================
+ Hits          1703     1733      +30     
  Misses         256      256              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@francescovallone francescovallone merged commit 4404949 into develop Jun 9, 2024
1 check passed
@francescovallone francescovallone deleted the feat/16 branch June 9, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants