Improve reconnection code and remove configurable timeouts#5
Merged
tom-james-watson merged 1 commit intomainfrom Feb 18, 2026
Merged
Improve reconnection code and remove configurable timeouts#5tom-james-watson merged 1 commit intomainfrom
tom-james-watson merged 1 commit intomainfrom
Conversation
tom-james-watson
requested review from
elmarburke
and removed request for
elmarburke
tom-james-watson
force-pushed
the
refactor/improve-reconnections
branch
from
d1abe71 to
e254450
Compare
tom-james-watson
force-pushed
the
refactor/improve-reconnections
branch
from
e254450 to
7faa296
Compare
elmarburke
approved these changes
Feb 18, 2026
Comment on lines
+203
to
+209
| export async function executeWithReconnect( | ||
| session: Session, | ||
| framer: Framer, | ||
| code: string, | ||
| options: ExecuteOptions, | ||
| reconnect: () => Promise<Framer | null>, | ||
| ): Promise<ExecuteResult> { |
There was a problem hiding this comment.
nit: make this an object, so the reconnect becomes labeled in usage
(low prio, because the reconnect has reconnect() in it)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the ability to configure a timeout, because agents are just always unnecessarily sending it. A hard limit of 10 minutes is probably fine.
Also moves the reconnection code around to get it out of the router and make it a little more cleaner. Also fixes a potential issue where parallel reconnections are attempted by reusing the same reconnection promise.