-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extra_javascript in mkdocs 1.5.0 is list of objects and no longer string #80
Comments
Thank you for your contribution! This is very appreciated. |
Fix extra_javascript config reading for mkdocs 1.5.0, see #80
Thanks for the fix! Is there an expectation for a pypi release? |
Not in the very next days. A new version is in preparation with updated documentation. |
This issue becomes redundant, since a patch was issued in mkdocs 1.5.1 (see mkdocs/mkdocs/#3310). |
The forcing to str will stay, even though it would still work with mkdocs 1.5.1. The use of fspath in path objects is not super obvious in its consequences; so for tranquillity of mind, forcing to str seems a good idea. |
According to the changelog, there is a set of changes to apply in order to be compatible with mkdocs 1.5.0 released on 26/27 July 2013.
See documentation here: https://www.mkdocs.org/about/release-notes/#upgrades-for-plugin-developers
I opened PR #79 to fix one of these issues, but I do not know if there is any other things to do.
The text was updated successfully, but these errors were encountered: