Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extra_javascript in mkdocs 1.5.0 is list of objects and no longer string #80

Closed
julienlavergne opened this issue Jul 27, 2023 · 5 comments
Labels
fixed The issue is fixed mkdocs Issue connected to mkdocs (evolution, etc.)

Comments

@julienlavergne
Copy link
Contributor

According to the changelog, there is a set of changes to apply in order to be compatible with mkdocs 1.5.0 released on 26/27 July 2013.

See documentation here: https://www.mkdocs.org/about/release-notes/#upgrades-for-plugin-developers

I opened PR #79 to fix one of these issues, but I do not know if there is any other things to do.

@github-actions
Copy link

Thank you for your contribution! This is very appreciated.

@fralau fralau changed the title Incompatibility with mkdocs 1.5.0 requires code changes Extra_javascript in mkdocs 1.5.0 is list of objects object and no longer string Jul 27, 2023
@fralau fralau added the mkdocs Issue connected to mkdocs (evolution, etc.) label Jul 27, 2023
fralau added a commit that referenced this issue Jul 27, 2023
Fix extra_javascript config reading for mkdocs 1.5.0, see #80
@fralau fralau closed this as completed Jul 27, 2023
@fralau fralau changed the title Extra_javascript in mkdocs 1.5.0 is list of objects object and no longer string extra_javascript in mkdocs 1.5.0 is list of objects and no longer string Jul 27, 2023
@fralau fralau added the fixed The issue is fixed label Jul 27, 2023
@michaelvay
Copy link

michaelvay commented Jul 27, 2023

Thanks for the fix! Is there an expectation for a pypi release?

@fralau
Copy link
Owner

fralau commented Jul 27, 2023

Not in the very next days. A new version is in preparation with updated documentation.

@fralau
Copy link
Owner

fralau commented Jul 28, 2023

This issue becomes redundant, since a patch was issued in mkdocs 1.5.1 (see mkdocs/mkdocs/#3310).

@fralau fralau reopened this Jul 28, 2023
@fralau
Copy link
Owner

fralau commented Jul 28, 2023

The forcing to str will stay, even though it would still work with mkdocs 1.5.1. The use of fspath in path objects is not super obvious in its consequences; so for tranquillity of mind, forcing to str seems a good idea.

@fralau fralau closed this as completed Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed The issue is fixed mkdocs Issue connected to mkdocs (evolution, etc.)
Projects
None yet
Development

No branches or pull requests

3 participants