Skip to content

Commit

Permalink
fix: add image sha to dockerfile (#2234)
Browse files Browse the repository at this point in the history
  • Loading branch information
subomi authored Feb 3, 2025
1 parent 9608d7e commit 1f7c174
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/build-rolling-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ jobs:
${{ env.IMAGE_NAME }}:${{ env.SHORT_SHA }}-${{ matrix.arch }}
build-args: |
ARCH=${{ matrix.arch }}
IMAGE_SHA=${{ env.SHORT_SHA }}
- name: Confirm Pushed Images
run: aws ecr describe-images --repository-name convoy-rolling-updates --image-ids imageTag=${{ env.SHORT_SHA }}-${{ matrix.arch }}
Expand Down
6 changes: 6 additions & 0 deletions release.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
FROM alpine:3.20.2

# Define a build-time argument
ARG IMAGE_SHA

# Set an environment variable using the ARG
ENV CORE_GATEWAY_IMAGE_SHA=${IMAGE_SHA}

COPY convoy /cmd
COPY configs/local/start.sh /start.sh
RUN chmod +x /cmd
Expand Down

0 comments on commit 1f7c174

Please sign in to comment.