Direct Write Buffer #125
Open
Direct Write Buffer #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i designed it around your suggestions and maintaining your indirection design... the only issue is that this requires passing
TValuehas a template parameter todirectWriteBufferbecauseAdapterisn't defined whendirectWriteBufferis defined, thus we can't accessAdapter'sTValueparameter-- but not a big deal.and i disabled
allocateForDirectWriteinBasicOutputStreamAdapter.. i think that's the only other output adapter? i didn't see any others but if there are i can add disable functions in them if you point them out to me.