Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import pre 2.11 bug #2227

Merged
merged 5 commits into from
Jan 28, 2025
Merged

Conversation

ychiucco
Copy link
Collaborator

@ychiucco ychiucco commented Jan 28, 2025

closes #2226

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I added logging to new code - if appropriate.
  • I merged main into the current branch.

@ychiucco ychiucco linked an issue Jan 28, 2025 that may be closed by this pull request
@ychiucco ychiucco requested a review from tcompa January 28, 2025 16:05
@ychiucco ychiucco marked this pull request as ready for review January 28, 2025 16:05
Copy link

github-actions bot commented Jan 28, 2025

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 0.8 0.9 0.89 0.0 0.0
power 0.8 0.8 1.00 0.0 0.0
dataset 0.8 0.8 1.00 0.0 0.0
project 0.7 0.8 0.87 0.0 0.0
job 0.8 0.8 1.00 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 9.5 11.6 0.82 0.6 0.6
power 364.9 389.0 0.94 345.4 345.4
dataset 135.6 138.5 0.98 123.2 123.2
project 38.4 42.3 0.91 43.9 43.9
job 25.9 27.9 0.93 29.7 29.7

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.5 6.6 0.98 2.2 2.2
power 124.3 134.1 0.93 662.6 662.6
dataset 129.2 138.9 0.93 916.0 916.0
project 43.5 46.4 0.94 287.2 287.2
job 40.0 41.8 0.96 227.6 227.6

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 7.4 8.0 0.93 0.1 0.1
power 7.0 7.9 0.89 0.1 0.1
dataset 7.1 7.9 0.90 0.1 0.1
project 8.7 9.9 0.88 2.3 2.3
job 6.9 8.2 0.84 0.1 0.1

GET /api/v2/task/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.1 6.7 0.91 0.8 0.8
power 6.1 6.7 0.91 0.8 0.8
dataset 5.9 6.5 0.91 0.8 0.8
project 6.2 6.9 0.90 0.8 0.8
job 5.9 6.8 0.87 0.8 0.8

GET /api/v2/task-group/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 7.2 8.8 0.82 1.6 1.6
power 6.7 8.1 0.83 1.6 1.6
dataset 6.8 8.2 0.83 1.6 1.6
project 6.9 7.7 0.90 1.6 1.6
job 6.8 8.8 0.77 1.6 1.6

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 10.9 12.2 0.89 0.8 0.8
power 23.1 25.4 0.91 28.0 28.0
dataset 18.5 21.6 0.86 16.2 16.2
project 20.7 23.6 0.88 20.4 20.4
job 10.4 12.6 0.83 0.8 0.8

POST /api/v2/project/3/dataset/409/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 142.5 149.8 0.95 275.1 275.1

GET /auth/current-user/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 4.9 5.7 0.86 0.2 0.2
power 4.6 5.4 0.85 0.2 0.2
dataset 4.5 5.5 0.82 0.2 0.2
project 4.5 5.5 0.82 0.2 0.2
job 4.5 5.2 0.87 0.1 0.1

POST /auth/token/login/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 274.8 274.6 1.00 0.2 0.2

Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server/app/runner/executors/slurm/sudo
  executor.py
  fractal_server/app/schemas/v2
  workflowtask.py
Project Total  

This report was generated by python-coverage-comment-action

@ychiucco ychiucco merged commit b54c1b3 into main Jan 28, 2025
@ychiucco ychiucco deleted the 2226-fix-import-of-pre-211-workflows-into-211 branch January 28, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix import of pre-2.11 workflows into 2.11
2 participants