Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify compatibility between WorkflowTaskV2.type_filters and TaskV2.input_types #2196

Conversation

ychiucco
Copy link
Collaborator

@ychiucco ychiucco commented Jan 21, 2025

closes #2193

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I added logging to new code - if appropriate.
  • I merged main into the current branch.

Copy link

github-actions bot commented Jan 21, 2025

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 0.8 0.8 1.00 0.0 0.0
power 0.8 0.8 1.00 0.0 0.0
dataset 0.8 0.8 1.00 0.0 0.0
project 0.8 0.8 1.00 0.0 0.0
job 0.8 0.8 1.00 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 9.9 9.4 1.05 0.6 0.6
power 366.5 396.7 0.92 345.4 366.2
dataset 131.2 150.8 0.87 123.2 134.0
project 37.7 47.8 0.79 43.9 47.2
job 22.4 27.6 0.81 29.7 32.4

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.5 6.9 0.94 2.2 2.2
power 126.9 137.6 0.92 662.6 652.2
dataset 128.2 142.9 0.90 916.0 905.2
project 41.9 46.1 0.91 287.2 283.8
job 37.2 41.0 0.91 227.6 224.9

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 7.6 7.5 1.01 0.1 0.1
power 7.4 7.1 1.04 0.1 0.1
dataset 6.9 7.6 0.91 0.1 0.1
project 8.5 9.9 0.86 2.3 2.3
job 6.9 7.5 0.92 0.1 0.1

GET /api/v2/task/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.1 6.1 1.00 0.8 0.8
power 6.0 6.5 0.92 0.8 0.8
dataset 5.9 6.4 0.92 0.8 0.8
project 6.2 6.6 0.94 0.8 0.8
job 6.0 6.4 0.94 0.8 0.8

GET /api/v2/task-group/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 7.3 8.2 0.89 1.6 1.6
power 6.7 7.8 0.86 1.6 1.6
dataset 6.7 7.5 0.89 1.6 1.6
project 6.7 7.5 0.89 1.6 1.6
job 6.6 7.4 0.89 1.6 1.6

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 10.6 12.5 0.85 0.8 0.8
power 23.2 27.0 0.86 28.0 29.1
dataset 18.2 20.6 0.88 16.2 16.7
project 20.9 23.2 0.90 20.4 21.0
job 10.3 11.3 0.91 0.8 0.8

POST /api/v2/project/3/dataset/405/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 133.4 141.6 0.94 275.1 275.1

GET /auth/current-user/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 4.8 5.1 0.94 0.2 0.2
power 4.7 4.7 1.00 0.2 0.2
dataset 4.7 4.5 1.04 0.2 0.2
project 4.6 4.8 0.96 0.2 0.2
job 4.6 4.8 0.96 0.1 0.1

POST /auth/token/login/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 272.9 274.1 1.00 0.2 0.2

Copy link

github-actions bot commented Jan 21, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server/app/routes/api/v2
  _aux_functions_tasks.py
  images.py
  submit.py
  workflow_import.py
  workflowtask.py
  fractal_server/app/runner/executors/slurm/ssh
  executor.py
Project Total  

This report was generated by python-coverage-comment-action

@tcompa tcompa marked this pull request as ready for review January 21, 2025 13:27
@ychiucco ychiucco requested a review from tcompa January 21, 2025 14:58
CHANGELOG.md Show resolved Hide resolved
@ychiucco ychiucco merged commit ea22898 into dev-2.11 Jan 21, 2025
@ychiucco ychiucco deleted the 2193-verify-compatibility-between-workflowtaskv2type_filters-and-taskv2input_types branch January 21, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify compatibility between WorkflowTaskV2.type_filters and TaskV2.input_types
2 participants