Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UserSettings.cache_dir #2121

Merged
merged 7 commits into from
Dec 3, 2024

Conversation

ychiucco
Copy link
Collaborator

@ychiucco ychiucco commented Dec 3, 2024

closes #1992

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I added logging to new code - if appropriate.
  • I merged main into the current branch.

@ychiucco ychiucco linked an issue Dec 3, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Dec 3, 2024

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 0.9 0.8 1.12 0.0 0.0
power 0.8 0.8 1.00 0.0 0.0
dataset 0.8 0.8 1.00 0.0 0.0
project 0.8 0.8 1.00 0.0 0.0
job 0.8 0.9 0.89 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 10.4 10.0 1.04 0.6 0.6
power 395.8 389.4 1.02 366.2 366.2
dataset 152.7 148.1 1.03 134.0 134.0
project 48.0 43.7 1.10 47.2 47.2
job 27.2 26.3 1.03 32.4 32.4

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.9 6.4 1.08 2.2 2.2
power 140.5 139.7 1.01 652.0 652.0
dataset 141.5 139.6 1.01 904.8 904.8
project 46.8 45.5 1.03 283.7 283.7
job 39.9 38.8 1.03 224.8 224.8

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 8.0 7.6 1.05 0.1 0.1
power 8.4 7.5 1.12 0.1 0.1
dataset 7.7 7.5 1.03 0.1 0.1
project 9.3 9.1 1.02 2.3 2.3
job 7.5 7.7 0.97 0.1 0.1

GET /api/v2/task/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.6 6.1 1.08 0.8 0.8
power 6.4 6.1 1.05 0.8 0.8
dataset 6.5 6.4 1.02 0.8 0.8
project 6.1 6.0 1.02 0.8 0.8
job 6.7 6.0 1.12 0.8 0.8

GET /api/v2/task-group/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 8.3 7.5 1.11 1.6 1.6
power 7.4 7.5 0.99 1.6 1.6
dataset 7.4 7.4 1.00 1.6 1.6
project 8.2 7.4 1.11 1.6 1.6
job 7.8 7.4 1.05 1.6 1.6

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 12.0 11.6 1.03 0.8 0.8
power 26.3 25.3 1.04 29.1 29.1
dataset 19.5 19.3 1.01 16.7 16.7
project 23.3 22.8 1.02 21.0 21.0
job 13.3 11.3 1.18 0.8 0.8

POST /api/v2/project/3/dataset/413/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 151.2 150.3 1.01 275.1 275.1

GET /auth/current-user/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 5.0 4.9 1.02 0.2 0.2
power 4.9 4.8 1.02 0.2 0.2
dataset 5.3 4.8 1.10 0.2 0.2
project 5.4 4.6 1.17 0.2 0.2
job 5.2 4.7 1.11 0.1 0.1

POST /auth/token/login/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 274.5 274.1 1.00 0.2 0.2

Copy link

github-actions bot commented Dec 3, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server/app
  user_settings.py
  fractal_server/app/models
  user_settings.py
  fractal_server/app/routes/api/v1
  project.py
  fractal_server/app/routes/api/v2
  submit.py
  fractal_server/app/runner/executors/slurm/sudo
  executor.py
  fractal_server/app/runner/v2/_local_experimental
  executor.py
  fractal_server/app/schemas
  user_settings.py
Project Total  

This report was generated by python-coverage-comment-action

[skip ci]
CHANGELOG.md Show resolved Hide resolved
@tcompa tcompa merged commit 5e20e84 into main Dec 3, 2024
18 checks passed
@tcompa tcompa deleted the 1992-remove-cache_dir-and-use-project_dirfractal_cache branch December 3, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove cache_dir and use project_dir/.fractal_cache
2 participants