[js] do not consider the empty string a valid JS identifier (closes H…

…axeFoundation#3908)
fponticelli · Feb 23, 2015 · 6018767 · 6018767
1 parent c13be74
commit 6018767
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/genjs.ml b/genjs.ml
@@ -112,7 +112,7 @@ let kwds2 =
 	h
 
 let valid_js_ident s =
-	try
+	String.length s > 0 && try
 		for i = 0 to String.length s - 1 do
 			match String.unsafe_get s i with
 			| 'a'..'z' | 'A'..'Z' | '$' | '_' -> ()

diff --git a/tests/unit/src/unitstd/Map.unit.hx b/tests/unit/src/unitstd/Map.unit.hx
@@ -149,7 +149,6 @@ map.exists(c) == true;
 map.get(b) == null;
 
 // [] access
-/*
 var map = new Map();
 map["foo"] == null;
 map["foo"] = 12;
@@ -165,4 +164,5 @@ map[(function(s) return s + "o")("fo")] == 1;
 map["bar"] = map["foo"] = 9;
 map["bar"] == 9;
 map["foo"] == 9;
-*/
+
+['' => ''].keys().next() == '';