fix(test): extract shared test utilities and fix infrastructure issues#317
Merged
fix(test): extract shared test utilities and fix infrastructure issues#317
Conversation
- Extract MOCK_USER and EVENT_DEFAULTS into shared test-utils.ts with createMockLoadEvent() factory and createMockCookies() helper - Update root layout, (app) layout, and login page tests to import from shared module instead of duplicating setup - Fix vi.stubGlobal leak in health.test.ts by adding vi.unstubAllGlobals() in afterEach and re-stubbing document in beforeEach - Remove passWithNoTests: true from vitest config now that the project has substantial test coverage Closes #300 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MOCK_USERandEVENT_DEFAULTSfrom 3 test files into a sharedsrc/frontend/src/test-utils.tsmodule withcreateMockLoadEvent()factory andcreateMockCookies()helpervi.stubGloballeak inhealth.test.tsby addingvi.unstubAllGlobals()inafterEach(and re-stubbingdocumentinbeforeEachsince the cleanup removes it between tests)passWithNoTests: truefrom vitest config — the project now has 217 tests across 10 test files, so this safety net is no longer needed and would mask accidental test deletionCloses #300
Test plan
pnpm run test)svelte-checkpasses with 0 errors🤖 Generated with Claude Code