Add Accept header to requests in NetworkLoader #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows development servers to serve the correct file type. For more information see ElMassimo/vite_ruby#93 (comment)
|
I was about to open it, thanks ! |
|
Makes sense! Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📖
This pull request adds the
Acceptheaders to requests made by theNetworkLoaderstrategy.This allows development servers which can serve different file types—such as Vite.js—to serve a CSS file as expected.
This change should be backwards-compatible as any server that was previously responding with CSS content should continue to do so.
Background 📜
Vite.js can serve JS content for a given CSS file path, which allows it to provide hot-refresh for stylesheets.
For more information, see ElMassimo/vite_ruby#93 (comment)