Use hast-util-to-string to get heading text (github#17576)

fpehar · Jan 29, 2021 · 53ad15c · 53ad15c
1 parent 4f0f4cc
commit 53ad15c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/lib/render-content/plugins/use-english-headings.js b/lib/render-content/plugins/use-english-headings.js
@@ -1,5 +1,6 @@
 const GithubSlugger = require('github-slugger')
 const Entities = require('html-entities').XmlEntities
+const toString = require('hast-util-to-string')
 const visit = require('unist-util-visit')
 const slugger = new GithubSlugger()
 const entities = new Entities()
@@ -14,7 +15,8 @@ module.exports = function useEnglishHeadings ({ englishHeadings }) {
   if (!englishHeadings) return
   return tree => {
     visit(tree, matcher, node => {
-      const text = node.children.find(n => n.type === 'text').value
+      // Get the plain text content of the heading node
+      const text = toString(node)
       // find English heading in the collection
       const englishHeading = englishHeadings[entities.encode(text)]
       // get English slug

diff --git a/package.json b/package.json
@@ -51,6 +51,7 @@
     "hast-util-from-parse5": "^6.0.1",
     "hast-util-parse-selector": "^2.2.5",
     "hast-util-select": "^4.0.2",
+    "hast-util-to-string": "^1.0.4",
     "hastscript": "^6.0.0",
     "helmet": "^3.21.2",
     "highlightjs-graphql": "^1.0.2",
@@ -162,7 +163,7 @@
     "website-scraper": "^4.2.0"
   },
   "scripts": {
-    "start": "cross-env NODE_ENV=development ENABLED_LANGUAGES='en,ja' nodemon server.js",
+    "start": "cross-env NODE_ENV=development ENABLED_LANGUAGES='en,cn' nodemon server.js",
     "dev": "npm start",
     "debug": "cross-env NODE_ENV=development ENABLED_LANGUAGES='en,ja' nodemon --inspect server.js",
     "rest-dev": "script/rest/update-files.js && npm run dev",