Refactor User Authentication Strategies #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `githubStrategy.js` and `googleStrategy.js` to ensure consistent handling of user data and improved error handling. - Restructured user payloads in both strategies to match the new schema, ensuring that GitHub and Google specific data are correctly nested. - Added a new function `getByGoogleId` in `service.js` to retrieve users by their Google ID, enhancing the service layer's functionality. - Improved the user creation and update logic to maintain consistency across different authentication methods. - Enhanced logging for better traceability of user actions and errors.
- Extract duplicated authentication callback logic into reusable function - Create handleAuthCallback helper that works for both GitHub and Google strategies - Reduce code duplication while maintaining existing functionality - Keep strategy-specific logging for GitHub callbacks
|
foyzulkarim
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
githubStrategy.jsandgoogleStrategy.jsto ensure consistent handling of user data and improved error handling.getByGoogleIdinservice.jsto retrieve users by their Google ID, enhancing the service layer's functionality.