Skip to content

Add role management functionality and refactor navigation #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2024

Conversation

foyzulkarim
Copy link
Owner

@foyzulkarim foyzulkarim commented Nov 10, 2024

Description:

This PR implements role management functionality and includes several refactoring improvements to our navigation and component structure.

Changes:

  1. Role Management Features:
  • Added new role-related components:
    • RolePage - Main container with Helmet for SEO
    • RoleView - Core role management interface
    • RoleDialog - Form dialog for create/update operations
    • RoleTableHead - Sortable table headers
    • RoleTableRow - Individual role entries
    • RoleTableToolbar - Search/filter functionality
    • TableNoData - Empty state component
  1. Navigation & Component Refactoring:
  • Updated config-navigation.jsx:
    • Revised navigation titles and paths
    • Updated icon implementations
    • Added role management section
  • Component organization improvements:
    • Moved TextHighlight to dedicated component
    • Added proper component exports
    • Implemented lazy loading for RolePage in sections.jsx
  • Removed unused hooks (useState, useEffect)
  • Updated dependencies in yarn.lock
  1. Route Configuration:
  • Added new role management route in paths.js

Dependencies:

  • Please run npm install to update dependencies

Note:

This PR combines both the role management feature implementation and related refactoring changes as they are tightly coupled.

Related PR

foyzulkarim/commitstreams-server#16

…mports

- Update navigation titles, paths, and icons in config-navigation
- Add lazy import for RolePage component in sections.jsx
- Replace TextHighlight component with direct import
- Remove unused hooks (useState, useEffect)
- Clean up dependencies in yarn.lock
- Add role creation form with validation using yup and react-hook-form
- Update role table to display display name column
- Add create role button in toolbar
- Replace RoleDialog with RoleCreateForm component
- Update dependencies for form validation (@hookform/resolvers, yup)

This commit implements the client-side functionality for creating and updating roles.
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
6.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@foyzulkarim foyzulkarim changed the title Feature/rbac/role crud Add role management functionality and refactor navigation Nov 10, 2024
@foyzulkarim foyzulkarim marked this pull request as ready for review November 10, 2024 11:09
@foyzulkarim foyzulkarim merged commit 67c7fae into main Nov 10, 2024
1 check failed
@foyzulkarim foyzulkarim deleted the feature/rbac/role-crud branch November 10, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant