Repository navigation
Conversation
Signed-off-by: MrCroxx <mrcroxx.cs@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Foyer now depends directly on upstream Tokio. Remove the simulation runtime dependency, the
foyer-tokioadapter crate, runtime-selection features, conditional compilation, CI job, xtask command, and related changelog references.Breaking change: remove
runtime-tokioandruntime-madsim-tokio. Consumers should remove these feature selections; Tokio is used automatically, including withdefault-features = false.Validation:
strict_assertions: 113 passed and 1 skipped each.The benchmark's existing
tracingandtokio-consolesetup functions cannot be enabled together, so those configurations were checked separately as in CI.Downstream simulation compatibility: RisingWave currently locks foyer 0.22.3 and enables
runtime-madsim-tokio. Its existing locked build is unaffected, but migrating to this change requires a downstream simulation adapter. Removing the feature selection alone leaves foyer using real Tokio: a focused test reproducedSpawner::current()panicking inside a madsim runtime. A crates.io patch alias cannot replace thetokiopackage withmadsim-tokio; a same-name forwarding shim also creates a dependency cycle because madsim itself depends on Tokio. The pinned madsim runtime additionally lacksshutdown_background(), which foyer now calls unconditionally.