Skip to content

fix build on latest nightly#109

Merged
MrCroxx merged 2 commits into
foyer-rs:mainfrom
xxchan:xxchan/horizontal-raven
Aug 22, 2023
Merged

fix build on latest nightly#109
MrCroxx merged 2 commits into
foyer-rs:mainfrom
xxchan:xxchan/horizontal-raven

Conversation

@xxchan
Copy link
Copy Markdown
Contributor

@xxchan xxchan commented Aug 21, 2023

What's changed and what's your intention?

dtolnay/thiserror#246

rust-lang/rust#113464

@MrCroxx BTW, can I update risingwave's foyer dependency to latest now?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have passed make check and make test in my local envirorment.

Related issues or PRs (optional)

@MrCroxx MrCroxx self-requested a review August 22, 2023 06:30
Copy link
Copy Markdown
Member

@MrCroxx MrCroxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

BTW, can I update risingwave's foyer dependency to latest now?
@xxchan Yes!

@MrCroxx MrCroxx enabled auto-merge (squash) August 22, 2023 06:32
@MrCroxx MrCroxx disabled auto-merge August 22, 2023 06:32
@MrCroxx MrCroxx enabled auto-merge (squash) August 22, 2023 06:32
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx MrCroxx merged commit c826f70 into foyer-rs:main Aug 22, 2023
MrCroxx pushed a commit that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants