Fixing silent failure in parsing implementation#6
Open
sholderbach wants to merge 3 commits intofoyer-rs:mainfrom
Open
Fixing silent failure in parsing implementation#6sholderbach wants to merge 3 commits intofoyer-rs:mainfrom
sholderbach wants to merge 3 commits intofoyer-rs:mainfrom
Conversation
The way the parse was implemented accepted additional numeric characters or `.` after the first valid `f64` literal but ignored them. This permitted more strings that are invalid following a strict grammar for byte sizes and silently ignores the further symbols without error. ``` 1.0 ...KB 1.0 42.0 B ``` This change makes those illegal. `1 000 B` was also subject to the bad `skip_while` ignoring the following `000`. In this version of the fix whitespace is not accepted as a digit separator. So it will raise an error if the user doesn't explicitly strip the whitespace instead of reporting a wrong value. Signed-off-by: sholderbach <sholderbach@users.noreply.github.com>
Signed-off-by: sholderbach <sholderbach@users.noreply.github.com>
More following the old choices of using `f64::from_str` Signed-off-by: sholderbach <sholderbach@users.noreply.github.com>
sholderbach
force-pushed
the
parsing-fix-replay
branch
from
6a22f35 to
9b525b4
Compare
|
released original |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replay of bytesize-rs#59