Skip to content

ci: 添加常用 feature 组合检查 (#47)#102

Merged
foxzool merged 2 commits intomainfrom
fix/issue-47-ci-feature-checks
Apr 9, 2026
Merged

ci: 添加常用 feature 组合检查 (#47)#102
foxzool merged 2 commits intomainfrom
fix/issue-47-ci-feature-checks

Conversation

@foxzool
Copy link
Copy Markdown
Owner

@foxzool foxzool commented Apr 9, 2026

摘要

修复 Issue #47:添加 CI checks 用于常用 feature 组合。

变更内容

1. 更新 ci.yml

在 CI 工作流中新增 任务,测试以下组合:

  • 基础组合(15个):单个模块测试(auth, communication, docs, hr 等)
  • 文档细分组合(4个):docs-base, docs-bitable, docs-drive, docs-full
  • Webhook 组合(4个):webhook, webhook-card, webhook-signature, webhook-full
  • 推荐业务组合(6个):essential, enterprise 及常用多模块组合
  • 高价值组合(6个):多模块协作场景
  • Edge Cases(2个):no-default-features 和 full

2. 新增 FEATURE_MATRIX.md

创建文档说明 feature 矩阵测试策略:

  • Feature 分类表(核心/高级/推荐组合)
  • 维护策略和检查清单
  • 本地验证命令
  • 故障排除指南

验收标准

  • ✅ CI 中新增常用 feature 组合检查
  • ✅ 组合清单有明确维护策略(见 FEATURE_MATRIX.md)
  • ✅ 覆盖 no-default-features、默认 features、常见业务组合和 all-features
  • ✅ 新增 feature 或 feature 重构后能触发相应回归校验

关联

Fixes #47

测试

  • 本地验证 feature 组合可编译
  • 检查 CI 配置语法正确

在 ci.yml 中新增 feature-combinations 任务,覆盖以下内容:

- 基础组合:单个模块测试(15个组合)
- 文档细分组合:docs-base, docs-bitable, docs-drive, docs-full
- Webhook 组合:webhook, webhook-card, webhook-signature, webhook-full
- 推荐业务组合:essential, enterprise 等常用组合
- 高价值组合:多模块协作场景(6个组合)
- Edge Cases:no-default-features 和 full

新增 docs/FEATURE_MATRIX.md 文档,包含:
- Feature 分类说明(核心/高级/推荐组合)
- CI 测试矩阵详细说明
- 维护策略和新增 Feature 检查清单
- 本地验证命令

Fixes #47
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 769142ad54

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +140 to +143
- name: Install Rust toolchain
uses: dtolnay/rust-toolchain@v1
with:
toolchain: ${{ env.CARGO_TOOLCHAIN }}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Request clippy component in feature-combination job

The new feature-combinations job runs cargo clippy but its toolchain setup only specifies toolchain and does not request clippy as a component. dtolnay/rust-toolchain installs with a minimal profile unless components are added, so this job can fail on runners that don’t already have cargo-clippy preinstalled (or when the preinstalled toolchain/cache changes), causing nondeterministic CI breakage. Add components: clippy in this job’s Rust toolchain step to make the lint step reliable.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

foxzool commented Apr 9, 2026

@codex address that feedback

@chatgpt-codex-connector
Copy link
Copy Markdown

Summary

  • 已根据 review feedback 在 feature-combinations job 的 Rust toolchain 安装步骤中显式添加 components: clippy,确保 cargo clippy 在不同 runner 上稳定可用、避免依赖预装环境导致的非确定性失败。
  • 变更已提交到当前分支,提交为 bf91580,并已创建后续 PR(on top of 原 PR)说明该修复。

Testing

  • git diff -- .github/workflows/ci.yml && git diff --check
  • nl -ba .github/workflows/ci.yml | sed -n '136,150p'

View task →

Copy link
Copy Markdown
Owner Author

foxzool commented Apr 9, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@foxzool foxzool merged commit c921bf1 into main Apr 9, 2026
77 of 111 checks passed
@foxzool foxzool deleted the fix/issue-47-ci-feature-checks branch April 9, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CI checks for common feature combinations

1 participant