Skip to content

id_token is string #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2025
Merged

id_token is string #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ef343c
id_token is string
afoster Feb 20, 2025
1668b4d
Adjust tests to expect id_token as string
afoster Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Events/XeroAuthorized.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ class XeroAuthorized
{
public string $token;
public string $refresh_token;
public array $id_token;
public string $id_token;
public string $expires;
public array $tenants;

Expand Down
2 changes: 1 addition & 1 deletion tests/Feature/Routes/CallbackTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public function test_you_can_get_callback_url()
Event::assertDispatched(XeroAuthorized::class, function (XeroAuthorized $event) {
$this->assertEquals('token', $event->token);
$this->assertEquals('refresh-token', $event->refresh_token);
$this->assertEquals(['token' => 'foo'], $event->id_token);
$this->assertEquals('foo', $event->id_token);
$this->assertEquals('1234', $event->expires);
$this->assertEquals([
[
Expand Down
4 changes: 1 addition & 3 deletions tests/TestSupport/Mocks/MockAccessToken.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,7 @@ public function hasExpired()
public function getValues()
{
return [
'id_token' => [
'token' => 'foo',
],
'id_token' => 'foo'
];
}

Expand Down
12 changes: 3 additions & 9 deletions tests/Unit/CredentialManagersTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,7 @@ public function test_you_can_get_credential_store_with_existing_data($sutClass,
$createExistingData($sut, $existingData = [
'token' => 'default-token',
'refresh_token' => 'default-refresh-token',
'id_token' => [
'token' => 'foo',
],
'id_token' => 'foo',
'expires' => $expires = strtotime('+1 hour'),
'tenants' => [
[
Expand Down Expand Up @@ -126,9 +124,7 @@ public function test_that_it_stores_data_correctly($sutClass, $setupFunction, $c
$this->assertEquals([
'token' => 'token',
'refresh_token' => 'refresh-token',
'id_token' => [
'token' => 'foo',
],
'id_token' => 'foo',
'expires' => '1234',
'tenants' => [
'tenant' => 'tenant_id',
Expand Down Expand Up @@ -161,9 +157,7 @@ public function test_that_it_can_refresh_its_token($sutClass, $setupFunction, $c
$this->assertEquals([
'token' => 'token',
'refresh_token' => 'refresh-token',
'id_token' => [
'token' => 'foo',
],
'id_token' => 'foo',
'expires' => '1234',
'tenants' => null,
], $sut->getData());
Expand Down