Add support for removing empty compendium browser filters, and implement it for weapon and armor groups and armor categories - #23036
Open
Cuingamehtar wants to merge 1 commit into
Conversation
…ent them for weapon and armor groups and armor categories
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change will allow removing some compendium browser filters that would come up with no items in them, in a similar fashion to how publication selection works. As the behavior is identical, the publication source helper also reuses it (but could be removed completely to use the new method).
It will also implement this behavior for weapon and armor groups to remove empty groups, and for armor categories to remove barding in Starfinder. I didn't find it necessary to implement it other categories and tabs.
@jfn4th Pretty much the functionality you've asked for in the other PR.