Half of one damage rounds down to 0 rather than 1

[LJSmith066]

as title, contrary to raw: "As normal, round down if you halve the damage (though 1 damage halved remains at a minimum of 1 damage)."

[stwlam]

Hi there, in order for your report to be actionable, we'll need reproduction steps.

[LJSmith066]

Hi there, in order for your report to be actionable, we'll need reproduction steps.

1. type "/r 1" in chant
2. take half damage
3. it is zero damage

tested in starfinder 2e for what it's worth, though I wouldn't expect something so fundamental to be different between it and pf2.

[steve148]

Can confirm I was also able to replicate this.

Looking further, I think the issue is related to this change.

#17531

When the code gets to the line linked below, maybeNumber is 0.5 (1 * 0.5), gets floored to 0 and ends up zero.

pf2e/src/module/system/damage/roll.ts

Line 472 in 5752c43

return typeof maybeNumber === "number" ? Math.max(Math.floor(maybeNumber), 0) : maybeNumber;