Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#4958] Allow features to be repeatable in item choice #4959

Merged
merged 1 commit into from
Jan 7, 2025
Merged

[#4958] Allow features to be repeatable in item choice #4959

merged 1 commit into from
Jan 7, 2025

Conversation

arbron
Copy link
Collaborator

@arbron arbron commented Jan 3, 2025

Adds "Repeatable" data to the prerequisite data on feat items. Repeatable features can be selected more than once inside an item choice advancement.

Closes #4958

@arbron
[#4958] Allow features to be repeatable in item choice
63afb70 
Adds "Repeatable" data to the prerequisite data on `feat` items.
Repeatable features can be selected more than once inside an item
choice advancement.

Closes #4958
@arbron arbron added this to the D&D5E 4.2.0 milestone Jan 3, 2025
@arbron arbron self-assigned this Jan 3, 2025
Fyorl
Fyorl approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@Fyorl Fyorl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some testing with a repeatable Agonizing Blast and I couldn't break it. The only thing I noticed was that you can't, for example, select Agonizing Blast twice at the same level, which is an understandable limitation at this time.

@arbron
Copy link
Collaborator Author

arbron commented Jan 7, 2025

I did some testing with a repeatable Agonizing Blast and I couldn't break it. The only thing I noticed was that you can't, for example, select Agonizing Blast twice at the same level, which is an understandable limitation at this time.

I'll add a todo to look into that one in the future.

@arbron arbron merged commit 4375393 into 4.2.x Jan 7, 2025
@arbron arbron deleted the repeatable-feats branch January 7, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fyorl Fyorl Fyorl approved these changes

Assignees

@arbron arbron

Labels
feature request system: advancement
Projects
None yet
Milestone
D&D5E 4.2.0
Development

Successfully merging this pull request may close these issues.

Add repeatable data to features, allow selecting repeatable items multiple times in ItemChoice advancement
2 participants
@arbron @Fyorl