Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cover statuses #4013

Merged
merged 5 commits into from
Sep 12, 2024
Merged

Add cover statuses #4013

merged 5 commits into from
Sep 12, 2024

Conversation

mattexdee
Copy link
Contributor

This will allow features which provide cover regardless of position to include an Active Effect that applies the relevant status. It can later be checked in AC calculations and dex saves.

@mattexdee mattexdee added this to the D&D5E 4.0.0 milestone Aug 20, 2024
@mattexdee mattexdee requested a review from arbron August 20, 2024 20:34
@mattexdee mattexdee self-assigned this Aug 20, 2024
@mattexdee mattexdee changed the title Cover status Add cover statuses Aug 20, 2024
@arbron arbron requested a review from Fyorl September 11, 2024 21:13
@arbron
Copy link
Collaborator

arbron commented Sep 11, 2024

Screenshot 2024-09-11 at 14 10 44

@krbz999
Copy link
Contributor

krbz999 commented Sep 11, 2024

Wonder if it would not be cleaner to add a single condition with 3 levels. It should not be too difficult to change the name of the effect at will, and this would also prevent users from applying several different types of cover at the same time.

lang/en.json Outdated Show resolved Hide resolved
@arbron
Copy link
Collaborator

arbron commented Sep 12, 2024

Wonder if it would not be cleaner to add a single condition with 3 levels. It should not be too difficult to change the name of the effect at will, and this would also prevent users from applying several different types of cover at the same time.

I think three statuses is good, because unlike exhaustion you don't cycle through levels of cover, you just apply the one you want directly. What I think I'll add is that when one level of cover is added it removes any current levels of cover.

@arbron arbron requested a review from Fyorl September 12, 2024 17:13
@arbron arbron merged commit f3b739f into 4.0.x Sep 12, 2024
@arbron arbron deleted the cover-status branch September 12, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants