Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3029] Add 'concentration' object in actor system data #3086

Merged

Conversation

krbz999
Copy link
Contributor

@krbz999 krbz999 commented Feb 20, 2024

This introduces a RollConfig field which shares some common data that all similar fields can have (eg initiative, skills, abilities).

The concentration property is for creatures only.

(Also fixes the documentation for the init property.)

  /*
   * @property {object} concentration
   * @property {string} concentration.ability   The ability used for concentration saving throws.
   * @property {string} concentration.bonus     The bonus provided to concentration saving throws.
   * @property {number} concentration.limit     The amount of items this actor can concentrate on.
   * @property {number} concentration.mode      The default advantage mode for this actor's concentration saving throws.
   * @property {object} concentration.roll
   * @property {number} concentration.roll.min  The minimum the d20 can roll.
   * @property {number} concentration.roll.max  The maximum the d20 can roll.
   */

@arbron arbron added this to the D&D5E 3.1.0 milestone Feb 21, 2024
@arbron arbron added the api label Feb 21, 2024
Copy link
Contributor

@Fyorl Fyorl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me, just one comment

module/data/shared/roll-config-field.mjs Outdated Show resolved Hide resolved
@krbz999 krbz999 requested a review from Fyorl February 29, 2024 10:54
Co-authored-by: Kim Mantas <kim.mantas@gmail.com>
@krbz999 krbz999 requested a review from Fyorl February 29, 2024 19:30
Copy link
Contributor

@Fyorl Fyorl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks very much Zhell

@Fyorl Fyorl merged commit 8080489 into foundryvtt:3.1.x Feb 29, 2024
@krbz999 krbz999 deleted the 3029-extend-data-model-for-concentration branch March 2, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants