-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2809, #2858, #2859] Add user configuration for status conditions #2846
Merged
arbron
merged 11 commits into
foundryvtt:3.0.x
from
krbz999:configurable-status-condition-properties
Feb 6, 2024
Merged
[#2809, #2858, #2859] Add user configuration for status conditions #2846
arbron
merged 11 commits into
foundryvtt:3.0.x
from
krbz999:configurable-status-condition-properties
Feb 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krbz999
changed the title
[#2795, #2809] Add user configuration for status conditions and exhaustion
[#2795, #2809, #2858, #2859] Add user configuration for status conditions and exhaustion
Feb 3, 2024
Would you be able to split the exhaustion changes from the other condition changes? I have a thought on the whole exhaustion design that I'd like to riff on that might take a bit longer but it would be good to get the other changes in the next version. |
Would it conflict? |
krbz999
changed the title
[#2795, #2809, #2858, #2859] Add user configuration for status conditions and exhaustion
[#2809, #2858, #2859] Add user configuration for status conditions and exhaustion
Feb 3, 2024
arbron
requested changes
Feb 4, 2024
arbron
approved these changes
Feb 4, 2024
arbron
reviewed
Feb 6, 2024
krbz999
changed the title
[#2809, #2858, #2859] Add user configuration for status conditions and exhaustion
[#2809, #2858, #2859] Add user configuration for status conditions
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding in some much needed user agency, a quick one-liner can now modify which condition does what.
Doesn't touch exhaustion.
Closes #2809.
Closes #2858.
Closes #2859.